Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon No.89】 Remove circle import Part4 #51128

Closed
wants to merge 5 commits into from

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Mar 2, 2023

PR types

Others

PR changes

Others

Describe

Details

  • 根据核心框架开源贡献赛道——其他 #50711 将jit下的import移动到文件头部
  • 本PR不对'from paddle.static.nn.control_flow import Assert' 进行解决,暂时仅对jit内部的循环引用问题进行梳理,待梳理完毕后再调整外部引用。

convert_operators.py在头部引用了paddle.fluid.dygraph.base 中_convert_into_variable,在函数中引用in_declarative_mode,可以直接移动到文件头部。

@paddle-bot
Copy link

paddle-bot bot commented Mar 2, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Mar 2, 2023
@Liyulingyue Liyulingyue changed the title 测试用,无需review 【Hackathon No.89】 Remove circle import Part4 Mar 4, 2023
@Liyulingyue Liyulingyue closed this Mar 4, 2023
@paddle-bot
Copy link

paddle-bot bot commented Mar 4, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@Liyulingyue Liyulingyue deleted the circle_import_3 branch March 4, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant