-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register custom kernel for some all_bakcend kernel #51639
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment
|
||
#ifdef PADDLE_WITH_CUSTOM_DEVICE | ||
PD_REGISTER_KERNEL(shape, | ||
Custom, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use ALL_BACKEND
to register all backends directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个会在后面支持,目前会优先删除CustomDevice中的对应Kernel,看是否有机制问题暴露
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是不是需要把PaddleCustomDevice里对应注册的Kernel删一下?
是的,需要这里先注册上,PaddleCustomDevice里的kernel才能删 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe
Pcard-67742
在PR51262的基础上,为flatten, numel, reshape, shape等设备无关kernel新增了Custom类型Kernel的注册。