Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHI decoupling] Move DataType* from paddle:experimental to phi namespace #51716

Merged
merged 15 commits into from
Mar 21, 2023
Merged

[PHI decoupling] Move DataType* from paddle:experimental to phi namespace #51716

merged 15 commits into from
Mar 21, 2023

Conversation

jinyouzhi
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

此为 #51470 后继：移动fluid下的，并切换data_type.h中DataType相关操作命名空间

@paddle-bot
Copy link

paddle-bot bot commented Mar 15, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Mar 15, 2023
@jinyouzhi jinyouzhi marked this pull request as ready for review March 16, 2023 03:00
@jinyouzhi
Copy link
Contributor Author

@From00 DataType命名空间迁移后续

@jinyouzhi jinyouzhi force-pushed the phi/dt_ns_phi branch 2 times, most recently from ae81420 to 2e6d641 Compare March 17, 2023 09:02
@jinyouzhi
Copy link
Contributor Author

@luotao1 @YuanRisheng 终于解决好XPU的冲突了，麻烦review一下。总结一下改动：

  • 将 DataType 及其相关成员从 paddle::experimental 移动到 phi
  • 为了解决冲突将xpu中 using float = xxx 替换为 using XPUTypeFP16 = xxx

@jinyouzhi
Copy link
Contributor Author

@YuanRisheng @luotao1 @From00 大佬们抽空看一下吧，不然每天都有新冲突T_T

From00
From00 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 4638a62 into PaddlePaddle:develop Mar 21, 2023
@jinyouzhi jinyouzhi deleted the phi/dt_ns_phi branch March 21, 2023 06:54
@From00 From00 mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@From00 From00 From00 approved these changes

Assignees

@luotao1 luotao1

@YuanRisheng YuanRisheng

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jinyouzhi @From00 @luotao1 @YuanRisheng