Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prim test for some ops #51749

Merged
merged 25 commits into from
Mar 27, 2023
Merged

add prim test for some ops #51749

merged 25 commits into from
Mar 27, 2023

Conversation

Charles-hit
Copy link
Contributor

@Charles-hit Charles-hit commented Mar 16, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Describe

Pcard-66975
add prim op test for tanh、 cast and dropout ops.

Charles-hit and others added 22 commits March 16, 2023 08:37
@Charles-hit
add tanh and cast prim test
24b6262
@Charles-hit
fix tanh test
4500431
@Charles-hit
fix 0-d test
c58b247
@Charles-hit
add sqrt fp16 prim test
544c82c
@Charles-hit
add public_python_api in prim test
b05be03
@Charles-hit
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
a4eed6a 
… add_public_python_api
@Charles-hit
fix test_squeeze2_op
7cc7bff
@Charles-hit
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
91bfff6 
… add_public_python_api
@Charles-hit
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
62f53e1 
… add_cast_prim_test
@Charles-hit
add tanh prim test
f7abb52
@Charles-hit
Merge commit 'refs/pull/51829/head' of https://github.com/PaddlePaddl…
c484c14 
…e/Paddle into add_cast_prim_test
@Charles-hit
add dropout prim test
3ff6442
@Aurelius84
[Dy2St]Fix clone for test state problem
630af2a
@Aurelius84
clean code
b3bcb59
@Charles-hit
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
3bd19ff 
… add_cast_prim_test
@Charles-hit
modify test_cumsum_op
88e337c
@Charles-hit
modify test_cumsum_op
6c24947
@Charles-hit
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
d772676 
… add_cast_prim_test
@Charles-hit
Merge commit 'refs/pull/51966/head' of https://github.com/PaddlePaddl…
f5529db 
…e/Paddle into add_cast_prim_test
@Charles-hit
fix dropout test
fe28e1f
@Charles-hit
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
4f26a5c 
… add_cast_prim_test
@Charles-hit
add dropout in cmake
b5e5d1a
@Charles-hit Charles-hit changed the title add tanh and cast prim test add prim test for some ops Mar 24, 2023
cxxly
cxxly approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@cxxly cxxly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for test_dropout_op.py

JiabinYang
JiabinYang approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xiaoguoguo626807
xiaoguoguo626807 approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/paddle/fluid/tests/unittests/test_cast_op.py
elif dtype == np.complex64:
raise ValueError("Not supported dtype %s" % dtype)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be replaced with paddle.dtype.

python/paddle/fluid/tests/unittests/test_dropout_op.py
@@ -366,6 +452,7 @@ def test_seed_cpu_place(self):
class TestDropoutOpError(unittest.TestCase):
def test_errors(self):
with program_guard(Program(), Program()):
paddle.enable_static()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use _static_guard ()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are equivalent.

zhiqiu
zhiqiu approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Charles-hit Charles-hit reopened this Mar 27, 2023
@Charles-hit Charles-hit merged commit e1674e8 into PaddlePaddle:develop Mar 27, 2023
@SigureMo SigureMo mentioned this pull request Mar 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoguoguo626807 xiaoguoguo626807 xiaoguoguo626807 approved these changes

@JiabinYang JiabinYang JiabinYang approved these changes

@cxxly cxxly cxxly approved these changes

@zhiqiu zhiqiu zhiqiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Charles-hit @zhiqiu @cxxly @JiabinYang @xiaoguoguo626807 @Aurelius84