Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix phi header and add ut, test=develop #51798

Closed
wants to merge 3 commits into from

Conversation

qili93
Copy link
Contributor

@qili93 qili93 commented Mar 17, 2023

PR types

Bug fixes

PR changes

Others

Describe

最近在独立PHI算子库的过程中,"paddle/phi/extension.h" 常常因为引入多余的fluid头文件而导致编译失败。增加 test_phi_extension_header.py 单测来保证安装后的PaddleWHL包支持通过引入 "paddle/phi/extension.h" 独立编译,而不会导致头文件找不到的问题。

之前修复过类似问题的PR见

#51244 此PR中解决了头文件 "context_pool_utils.h" 中包含fluid头文件而导致的问题

#51782 此PR中 "paddle/phi/api/profiler/trace_event_collector.h" 不会被 setup.py 打包到 site-packages 下的 paddle/include 目录,因此直接引用 "paddle/phi/extension.h" 会报 "paddle/phi/api/profiler/trace_event_collector.h" 头文件找不到的错误。

相关PR见 #51511

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Apr 23, 2023

Sorry to inform you that 3e66945's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@qili93
Copy link
Contributor Author

qili93 commented Feb 20, 2024

Close as already fixed in #60842

@qili93 qili93 closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant