Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle][UP028] using yield from #52059

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Mar 23, 2023

PR types

Others

PR changes

Others

Describe

#51729 case 13
ruff rules

UP028: Replace over loop with yield for yield from

yield from 是py3.3后加入的特性,随着py2相关代码退场,该规则可以被引入。该表达更为简洁,且具有更为全面的异常处理。

是否可以引入本 rule:✅ 可引入。
是否可引入自动修复:✅ 可引入。

@paddle-bot
Copy link

paddle-bot bot commented Mar 23, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

随着py2相关代码退场,该规则可以被引入

应该说明 Paddle 最低支持 Python 3.7,Python 3.6 已退场

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Mar 24, 2023

@Liyulingyue 卡住的CI需要rerun下

@luotao1 luotao1 merged commit 85e2075 into PaddlePaddle:develop Mar 25, 2023
@Liyulingyue Liyulingyue deleted the up28 branch April 6, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants