Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.55】add erf FP16 test and BF16 test #52136

Merged
merged 9 commits into from
Apr 14, 2023
Merged

【Hackathon No.55】add erf FP16 test and BF16 test #52136

merged 9 commits into from
Apr 14, 2023

Conversation

superwinner1
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

add erf FP16 test

@paddle-bot
Copy link

paddle-bot bot commented Mar 25, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Mar 25, 2023
@superwinner1
Copy link
Contributor Author

@ZzSean 辛苦review下~，谢谢

@superwinner1
Copy link
Contributor Author

@jzhang533 辛苦review下~，谢谢

@superwinner1 superwinner1 mentioned this pull request Mar 30, 2023
Closed
@superwinner1
Copy link
Contributor Author

@Vvsmile 麻烦review~下，谢谢啦

@Vvsmile
Copy link
Contributor

Vvsmile commented Apr 3, 2023

FP16单测看起来没有问题，但是任务表单里有BF16算子实现的补充任务，最好一块做了

@superwinner1 superwinner1 changed the title add erf FP16 test add erf FP16 test and BF16 test Apr 6, 2023
@superwinner1
Copy link
Contributor Author

@Vvsmile 麻烦再review~下，谢谢啦

@superwinner1 superwinner1 changed the title add erf FP16 test and BF16 test 【Hackathon No.55】add erf FP16 test and BF16 test Apr 13, 2023
@superwinner1
Copy link
Contributor Author

@Vvsmile 辛苦再review下，谢谢

@superwinner1
Copy link
Contributor Author

@ZzSean 辛苦review下，谢谢

ZzSean
ZzSean approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZzSean ZzSean merged commit eeb4d16 into PaddlePaddle:develop Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZzSean ZzSean ZzSean approved these changes

Assignees

@luotao1 luotao1

@Vvsmile Vvsmile

@ZzSean ZzSean

@Ligoml Ligoml

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@superwinner1 @Vvsmile @ZzSean @luotao1 @Ligoml