-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeStyle][PLR1722] replace exit()
with sys.exit()
#52151
[CodeStyle][PLR1722] replace exit()
with sys.exit()
#52151
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
❌ The PR is not created using PR's template. You can refer to this Demo. |
这里「部分 可引入」是什么意思,是说自动修复只能修复一部分吗? 另外在描述里说明一下这里为什么不建议使用
两个 PR 都没能通过 CheckPRTemplate,需要修改一下 |
exit()
with sys.exit()
需要解决下冲突 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已确定所有未加 import sys
的文件本身就已经 import 过了
解决冲突后 LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
怎么我 LGTM 的瞬间直接挂了一堆 CI……麻烦 re-run 下 PR-CI-Py3 |
PR types
Others
PR changes
Others
Describe
将
exit()
替换为sys.exit()
exit()
和sys.exit()
区别: https://stackoverflow.com/questions/6501121/difference-between-exit-and-sys-exit-in-python#51729 57
是否可以引入本 rule:Penidng on ci results 可引入。
是否可引入自动修复:部分 可引入