Delete the /paddle/fluid/platform/device/npu directory #52384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
其他一些部分引入了被删掉部分头文件造成 build 失败 |
luotao1
reviewed
Mar 31, 2023
| @@ -20,7 +20,6 @@ | |||
| #include "paddle/phi/common/amp_type_traits.h" | |||
|
|
|||
| #ifdef PADDLE_WITH_ASCEND_CL | |||
| #include "paddle/fluid/platform/device/npu/npu_op_runner.h" | |||
| #endif | |||
There was a problem hiding this comment.
去掉头文件后，前后的ifdef和endif空了，也可以去掉了。这个PR有多处这种情况，需要处理下。也可以下一个PR来处理。
luotao1
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
#52319