Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete WITH_ASCEND_CL #52825

Merged
merged 2 commits into from
Apr 13, 2023
Merged

delete WITH_ASCEND_CL #52825

merged 2 commits into from
Apr 13, 2023

Conversation

jjyaoao
Copy link
Contributor

@jjyaoao jjyaoao commented Apr 12, 2023

PR types

Others

PR changes

Others

Describe

#52319

@paddle-bot
Copy link

paddle-bot bot commented Apr 12, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -69,7 +69,7 @@ phi::DeviceContext* DeviceContextPool::Get(const phi::Place& place) {
if (it == ptr->end()) {
PADDLE_THROW(phi::errors::Unimplemented(
"Place %s is not supported. Please check that your paddle compiles "
"with WITH_GPU, WITH_XPU, WITH_IPU, WITH_MLU or WITH_ASCEND_CL option "
"with WITH_GPU, WITH_XPU, WITH_IPU or WITH_MLU option "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WITH_MLU 也可以删了

@@ -235,7 +235,7 @@ bool GetCondData(const phi::DenseTensor &cond) {
PADDLE_THROW(platform::errors::PreconditionNotMet(
"This version of PaddlePaddle does NOT support GPU/NPU/XPU but got "
"GPU/NPU/XPU tensor Cond in WhileOp. Please compile WITH_GPU or "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

两处 GPU/NPU/XPU 都可以改成 GPU/XPU

Copy link
Contributor

@ronny1996 ronny1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 4a374c6 into PaddlePaddle:develop Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants