Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zero-Dim] add 0D output support for linalg.slogdet #52891

Conversation

GGBond8488
Copy link
Contributor

@GGBond8488 GGBond8488 commented Apr 13, 2023

PR types

Others

PR changes

Others

Describe

add 0D output support for inalg.slogdet
Pcard-66984

@paddle-bot
Copy link

paddle-bot bot commented Apr 13, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@GGBond8488 GGBond8488 changed the title 【0D output】add 0D output support for inalg.slogdet 【0D output】add 0D output support for linalg.slogdet Apr 16, 2023
# 2-D input
x = paddle.randn([3, 3])
x.stop_gradient = False
out = paddle.linalg.slogdet(x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个需要append_backward才有反向,fetch一下x.grad_name试下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增加了静态图反向测试

Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit a7155c5 into PaddlePaddle:develop Apr 18, 2023
jjyaoao pushed a commit to jjyaoao/Paddle that referenced this pull request Apr 19, 2023
* add 0D output support for inalg.slogdet,test=allcase

* fix zerom dime test error test=allcase

* fix test error test=allcase

* add static backward test, test=allcase
@zhwesky2010 zhwesky2010 changed the title 【0D output】add 0D output support for linalg.slogdet [Zero-Dim] add 0D output support for linalg.slogdet May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants