Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relocate python/paddle/fluid/regularizer.py #53106

Merged
merged 10 commits into from
May 15, 2023

Conversation

longranger2
Copy link
Contributor

@longranger2 longranger2 commented Apr 20, 2023

PR types

Others

PR changes

APIs

Description

To clean the code in paddle.fluid, the useless codes should be removed and code still be used should move to a new position.

  • 将WeightDecayRegularizer、L1DecayRegularizer、L2DecayRegularizer迁移到paddle.regularizer下.

@paddle-bot
Copy link

paddle-bot bot commented Apr 20, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 20, 2023
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented May 3, 2023

Sorry to inform you that 45236dd's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.



L1Decay = L1DecayRegularizer
L2Decay = L2DecayRegularizer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L1Decay L1DecayRegularizer 现在是完全一致的了,类名是否直接使用前者即可,没必要保留后者了。 L2同理。

@@ -1,4 +1,4 @@
# Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved.
# Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不需要改动吧

Copy link
Contributor

@zoooo0820 zoooo0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paddle-bot
Copy link

paddle-bot bot commented May 12, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 merged commit 00e415d into PaddlePaddle:develop May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants