Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] fc use int_with_ll_t #53183

Merged
merged 3 commits into from
Apr 23, 2023
Merged

Conversation

houj04
Copy link
Contributor

@houj04 houj04 commented Apr 21, 2023

PR types

New features

PR changes

OPs

Description

  • 增加新的FC量化方式int_with_ll_t。由于bmm算子本质上也是FC,所以一起修改了。
  • 这个PR [Zero-Dim] Support output 0D for static.data #52775 会导致test_unbind_op_xpu单测跑不过,因此根据它的修改方式对应做了修改。

@paddle-bot
Copy link

paddle-bot bot commented Apr 21, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Apr 21, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

Copy link
Contributor

@taixiurong taixiurong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -30,6 +30,7 @@ enum XPUFCCalcType {
FC_INT16 = 0,
FC_INT32,
FC_FLOAT,
FC_INT_WITH_LL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下一个PR可以改下名字,FC_INT32和FC_INT_WITH_LL两个名字要么都是int,要么都是int32

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

@@ -41,6 +42,8 @@ XPUFCCalcType FCCalcType() {
return XPUFCCalcType::FC_INT32;
} else if (std::getenv("XPU_PADDLE_FC_LOCAL_INT16") != nullptr) {
return XPUFCCalcType::FC_FLOAT;
} else if (std::getenv("XPU_PADDLE_FC_INT_WITH_LL") != nullptr) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

环境变量同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

@houj04 houj04 merged commit 7634a18 into PaddlePaddle:develop Apr 23, 2023
lijialin03 pushed a commit to lijialin03/Paddle that referenced this pull request Apr 25, 2023
* [XPU] fc use int_with_ll_t

* fix test_unbind_op_xpu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants