-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon】64. einsum 算子 fp16单测完善 #53722
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
❌ The PR is not created using PR's template. You can refer to this Demo. |
for i in range(len(self.operands)) | ||
], | ||
} | ||
print(self.attrs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
去掉print语句
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
@@ -659,5 +660,58 @@ def test_shape(self): | |||
) | |||
|
|||
|
|||
def einsum_wrapper(a, b): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请在test_einsum_op.py中添加,fp16和bf16的单测各添加一个
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不好意思,这个可能是当时统计有误,你这段代码在test_einsum_op.py是有重复的,而且这个文件里都是OpTest,所以最好还是在这里加,统一起见bf16也加一个OpTest吧,v2里是APITest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改test_einsum_op.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Description
einsum 算子 fp16单测完善
![图片](https://private-user-images.githubusercontent.com/4617245/237611259-58558d74-af3f-406c-b8af-c56c1394beb1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MTk0MDUsIm5iZiI6MTczOTQxOTEwNSwicGF0aCI6Ii80NjE3MjQ1LzIzNzYxMTI1OS01ODU1OGQ3NC1hZjNmLTQwNmMtYjhhZi1jNTZjMTM5NGJlYjEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTNUMDM1ODI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDU3Y2IwY2JjOTZlNDZmNWM0MGI4YWI1MWQ5ZWE2NjRkN2ExMzQxYWFhMDc5Nzk3NzFiMTVhZDdjYjBiZjFiZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.pSW_dSGkcjmjxZhFOw0n5VW11ox0aOy08nNqotg97PE)