[IR&PASS] part 3-1: Add PatternMatch base class. #54385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiweibo
changed the title
yuanlehome
reviewed
Jun 6, 2023
|
|
||
| std::string debug_name() const { return debug_name_; } | ||
|
|
||
| void set_debug_name(const std::string& name) { debug_name_ = name; } |
There was a problem hiding this comment.
设值函数统一驼峰式命名，SetDebugName
| }; | ||
|
|
||
| //---------------------------------------------------------// | ||
| // Pattern Class |
|
|
||
| const std::vector<std::string>& debug_labels() const { return debug_labels_; } | ||
|
|
||
| void add_debug_labels(const std::vector<std::string>& labels) { |
| debug_labels_.insert(debug_labels_.end(), labels.begin(), labels.end()); | ||
| } | ||
|
|
||
| void add_debug_labels(const std::string& label) { |
| namespace ir { | ||
|
|
||
| //---------------------------------------------------------// | ||
| // Pattern Class |
There was a problem hiding this comment.
.cc里的这种注释可以参考pass.cc里的形式
| // const std::vector<std::string>& generated_names, | ||
| // PatternBenefit benefit, | ||
| // ir::IrContext* context); | ||
| std::string op_name_; |
| #include "paddle/utils/small_vector.h" | ||
| namespace ir { | ||
|
|
||
| /// The design is mainly from MLIR, very thanks to the greate project. |
|
|
||
| unsigned benefit() { return val_; } | ||
|
|
||
| bool operator==(const PatternBenefit& rhs) const { return val_ == rhs.val_; } |
| // op->erase(); | ||
| // } | ||
| void RewriterBase::EraseOp(Operation* op) { | ||
| // assert(op->use_empty() && "expected 'op' to have no uses"); |
There was a problem hiding this comment.
ir下有计划将assert和throw统一换成paddle下enforce和throw，后面需要统一改一下
| #include "paddle/ir/core/type_id.h" | ||
| #include "paddle/ir/core/type_name.h" | ||
| #include "paddle/ir/core/value.h" | ||
| #include "paddle/utils/small_vector.h" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-71500
新IR下的新PASS体系，新PASS体系适配新IR。该系列PR主要包括如下几个部分：
主要包括四个部分：(1) Pass base & PassManager & PassAdaptor; #54023 (2) AnalysisManager & Pass Instrumentation (PassTiming, IRPrinting..); #54170 #54308 #54348 (3) Pattern Rewrite ... (4) 其他。
后续PR：