Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] fix cmake with the same name already exists #54391

Merged
merged 3 commits into from
Jun 11, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Jun 6, 2023

PR types

Others

PR changes

Others

Description

BUG1:

修复重名文件无法覆盖的情况

不过这样可能会导致每次cmakemake -j都执行文件的解压缩

CMake Error at cmake/external/brpc.cmake:26 (add_library):
  add_library cannot create imported target "crypto" because another target
  with the same name already exists.
Call Stack (most recent call first):
  cmake/third_party.cmake:403 (include)
  CMakeLists.txt:566 (include)

BUG2:

leveldb为例, 如果直接修改, 将不会自动重新触发编译

set(LEVELDB_TAG v1.17)

目前有个解决方案就是在git checkout的时候去清除文件

# clean build file
 file(REMOVE_RECURSE ${LEVELDB_PREFIX_DIR})
 file(REMOVE_RECURSE ${LEVELDB_INSTALL_DIR})

暂时修复libmct,lapack,mklml

(bug2在此条pr修复,bug1不清楚是否需要修复,因为它并不会导致整个cmake失败)

@paddle-bot
Copy link

paddle-bot bot commented Jun 6, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Jun 6, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@gouzil gouzil deleted the fix_cmake_md5error branch June 6, 2023 10:49
@gouzil gouzil restored the fix_cmake_md5error branch June 8, 2023 12:11
@gouzil gouzil reopened this Jun 8, 2023
@gouzil gouzil changed the title [cmake] fix cmake download md5 check error [cmake] fix cmake with the same name already exists Jun 8, 2023
Copy link
Contributor

@risemeup1 risemeup1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit a6b9120 into PaddlePaddle:develop Jun 11, 2023
risemeup1 added a commit that referenced this pull request Jun 11, 2023
@gouzil gouzil deleted the fix_cmake_md5error branch September 24, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants