[IR]Lower pd op to kernel dialect #54469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add_kernel_dialect
… add_kernel_dialect
… lower_pd_op_to_kernel_dialect
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
… lower_pd_op_to_kernel_dialect
… lower_pd_op_to_kernel_dialect
zyfncg
reviewed
Jun 9, 2023
Comment on lines
122
to
125
| phi::Place cpu_place(phi::AllocationType::CPU); | ||
| auto ptr = new phi::Allocation(nullptr, 0, cpu_place); | ||
|
|
||
| std::shared_ptr<phi::Allocation> holder(ptr); |
There was a problem hiding this comment.
用CPUPlace fake Tensor的话是不就只能选CPU 的 kernel了？
There was a problem hiding this comment.
这是之前有个bug，暂时定义了一个 新的cpu place，应该用 type.place()
已经修改
… lower_pd_op_to_kernel_dialect
Shixiaowei02
previously approved these changes
Jun 12, 2023
zhangbo9674
reviewed
Jun 12, 2023
| namespace paddle { | ||
| namespace dialect { | ||
|
|
||
| phi::DataType convetIrType2DataType(ir::Type type) { |
There was a problem hiding this comment.
这个函数可以和paddle/fluid/ir/dialect/utils.h中的TransToPhiDataType复用
raindrops2sea
previously approved these changes
Jun 12, 2023
… lower_pd_op_to_kernel_dialect
chenwhql
reviewed
Jun 12, 2023
| #include "paddle/fluid/ir/dialect/pd_attribute.h" | ||
| #include "paddle/fluid/ir/dialect/utils.h" | ||
| #include "paddle/fluid/ir/interface/op_yaml_info.h" | ||
| #include "paddle/fluid/ir/pass/pd_op_to_kernel_pass.h" |
| } else if (type.isa<ir::Int32Type>()) { | ||
| return phi::DataType::INT32; | ||
| } else { | ||
| PADDLE_THROW("not shupport type for now", type); |
| @@ -92,14 +94,11 @@ template <typename T> | |||
| void build_context(ir::Operation* op, | |||
There was a problem hiding this comment.
code style不太统一，公共函数应该都是驼峰式
| .dyn_cast<paddle::dialect::AllocatedDenseTensorType>(); | ||
| kernel_data_type = type.dyn_cast<dialect::DataTypeAttribute>().data(); | ||
| } else { | ||
| PADDLE_ENFORCE_EQ(attr_type_map.count(slot_name), |
… lower_pd_op_to_kernel_dialect
raindrops2sea
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
支持将pd op lowering到 kernel dialect， 为后续打通执行器做准备
Other
Pcard-67164