[LAUNCH] no endpoints env in dynamic mode #54636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
LiYuRio
reviewed
Jun 19, 2023
Comment on lines
-284
to
-288
| if self.worker_num() == 1: | ||
| # if worker_num is 1, should construct default topology & hcg | ||
| self._topology = tp.CommunicateTopology() | ||
| self._hcg = tp.HybridCommunicateGroup(self._topology) | ||
| return |
There was a problem hiding this comment.
这里以后可以用get_world_size代替worker_num，这样创建全局通信组的逻辑就可以保留了，避免有人真的依赖这段逻辑，虽然看着并没有什么用
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
No need to set PADDLE_TRAINER_ENDPOINTS env in dynamic mode.
Pcard-71953