[IR] refine program translator #54719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
reviewed
Jun 19, 2023
Aurelius84
reviewed
Jun 19, 2023
…r_program_translator
… into refactor_program_translator
kangguangli
requested review from
Aurelius84,
winter-wang,
zyfncg,
heavyrain-lzy and
zhangbo9674
winter-wang
reviewed
Jun 30, 2023
| auto program = std::make_unique<Program>(ir::IrContext::Instance()); | ||
| ir::IrContext* ctx = ir::IrContext::Instance(); | ||
| ctx->GetOrRegisterDialect<dialect::PaddleDialect>(); | ||
| ctx->GetOrRegisterDialect<ir::BuiltinDialect>(); |
There was a problem hiding this comment.
BuiltinDialect会在构造函数里面自动注册，没必要重复
heavyrain-lzy
approved these changes
Jun 30, 2023
zyfncg
approved these changes
Jun 30, 2023
Aurelius84
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
This PR:
OpTranslator, which makes a single op translator will be the combinations of several function and thus reduce the cost of specializing translators for special ops.Others
Pcard-67164