Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修改 COPY-FROM No.5 nn #54889

Merged
merged 3 commits into from
Jun 30, 2023
Merged

修改 COPY-FROM No.5 nn #54889

merged 3 commits into from
Jun 30, 2023

Conversation

Li-fAngyU
Copy link
Contributor

@Li-fAngyU Li-fAngyU commented Jun 26, 2023 •
edited
Loading

PR types

Others

PR changes

Docs

Description

更新 paddle.nn 中部分类与接口的 docstring ，使支持新的中文文档生成方式。

@paddle-bot
Copy link

paddle-bot bot commented Jun 26, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 26, 2023
@Li-fAngyU Li-fAngyU mentioned this pull request Jun 26, 2023
Merged
@SigureMo SigureMo mentioned this pull request Jun 26, 2023
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 27, 2023
@luotao1 luotao1 self-assigned this Jun 27, 2023
sunzhongkai588
sunzhongkai588 reviewed Jun 27, 2023
View reviewed changes
python/paddle/nn/layer/transformer.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/container.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/container.py Show resolved Hide resolved
python/paddle/nn/layer/container.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/container.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/container.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/container.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/container.py Outdated Show resolved Hide resolved
@Li-fAngyU
Copy link
Contributor Author

谢谢审核，确实这样就重复添加了。所以修改nn下的COPYFROM无需更改Paddle库下的文件，仅需更改docs下的文件。

因此关闭该PR了。

@Li-fAngyU Li-fAngyU closed this Jun 27, 2023
@paddle-bot
Copy link

paddle-bot bot commented Jun 27, 2023

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@Li-fAngyU Li-fAngyU reopened this Jun 27, 2023
@Li-fAngyU
Copy link
Contributor Author

Done

@Li-fAngyU Li-fAngyU requested a review from sunzhongkai588 June 29, 2023 11:41
@luotao1 luotao1 merged commit 0f69d93 into PaddlePaddle:develop Jun 30, 2023
@Li-fAngyU Li-fAngyU deleted the copy_from_nn branch July 6, 2023 02:19
@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@sunzhongkai588 sunzhongkai588 Awaiting requested review from sunzhongkai588

Assignees

@luotao1 luotao1

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Li-fAngyU @luotao1 @sunzhongkai588