Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CUDNN Frontend API to v0.9.1 #54949

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Update CUDNN Frontend API to v0.9.1 #54949

merged 5 commits into from
Jul 14, 2023

Conversation

Tom-Zheng
Copy link
Contributor

PR types

Function optimization

PR changes

Others

Description

  • Remove old patches
  • Remove workarounds that are no longer needed
  • Reduce code redundancy
  • Improve cache implementation to avoid multi-thread problems

@Tom-Zheng
Update CUDNN Frontend API to v0.9.1
7b410ed 
- Remove old patches
- Remove workarounds that are no longer needed
@paddle-bot
Copy link

paddle-bot bot commented Jun 28, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 28, 2023
@Tom-Zheng
Copy link
Contributor Author

@tianshuo78520a It seems that PR-CI-Coverage-117-NV is broken. This PR will need to build with WITH_CUDNN_FRONTEND=ON, and tested with FLAGS_enable_cudnn_frontend=1. Do you think the new A100 pipeline is ready?

@Tom-Zheng
Copy link
Contributor Author

@tianshuo78520a has confirmed that PR-CI-OP-benchmark failure is a random failure and can be manually approved.
@Xreki would you please take a look?

@Tom-Zheng Tom-Zheng requested a review from Xreki June 29, 2023 09:13
@Tom-Zheng Tom-Zheng mentioned this pull request Jun 30, 2023
Merged
@Tom-Zheng
Copy link
Contributor Author

Tom-Zheng commented Jun 30, 2023 •
edited
Loading

Adding @jeng1220 @Wong4j for vis

@onecatcn onecatcn assigned onecatcn and Xreki and unassigned onecatcn Jul 1, 2023
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jul 8, 2023

Sorry to inform you that 1e1462a's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@Tom-Zheng
Copy link
Contributor Author

The pipelines have passed 7 days and need rerun. @tianshuo78520a Could you help rerun PR-CI-Coverage-117-NV ?
@Xreki Would you please take some time to review this PR?

Xreki
Xreki approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 有些小疑问，可以下个PR看下

paddle/phi/kernels/autotune/cache_cudnn_frontend.h

auto it = local_map.find(GetExtendedFeature(feature, handle));
if (it == local_map.end()) {
PADDLE_THROW(phi::errors::InvalidArgument(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以直接用PADDLE_ENFORCE_NE(it, local_map.end(), ...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下个PR修改

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed at #55026

paddle/phi/kernels/autotune/cache_cudnn_frontend.h
const cudnn_frontend::OperationGraph& op_graph,
cudnnHandle_t handle,
bool use_addto = false) {
void GetPlan(const cudnn_frontend::feature_vector_t &feature,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetPlan -> GetPlanAndWorkspaceSize

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下个PR修改

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed at #55026

paddle/phi/kernels/autotune/cache_cudnn_frontend.h Show resolved Hide resolved
@Xreki Xreki merged commit 76b77d8 into PaddlePaddle:develop Jul 14, 2023
@Tom-Zheng Tom-Zheng deleted the update_cudnn_fe branch July 14, 2023 02:30
cqulilujia pushed a commit to cqulilujia/Paddle that referenced this pull request Jul 24, 2023
@Tom-Zheng @cqulilujia
Update CUDNN Frontend API to v0.9.1 (PaddlePaddle#54949)
9f83707 
* Update CUDNN Frontend API to v0.9.1
- Remove old patches
- Remove workarounds that are no longer needed

* Fix test_switch_autotune
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
@Tom-Zheng @wz1qqx
Update CUDNN Frontend API to v0.9.1 (PaddlePaddle#54949)
7f3ecdf 
* Update CUDNN Frontend API to v0.9.1
- Remove old patches
- Remove workarounds that are no longer needed

* Fix test_switch_autotune
eee4017 pushed a commit to eee4017/Paddle that referenced this pull request Nov 8, 2023
@jeng1220
Merge branch 'tizheng/cherry-pick-update-cudnn-frontend' into 'rjeng/…
a5033cb 
…2.5'

[cherry-pick] Update CUDNN Frontend API to v0.9.1 (PaddlePaddle#54949)

See merge request dl/paddle/paddle!238

(cherry picked from commit bc0a7755a15cc493d7cc909bcdd4d64946584465)

68e79afb Update CUDNN Frontend API to v0.9.1 (PaddlePaddle#54949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xreki Xreki Xreki approved these changes

Assignees

@Xreki Xreki

Labels
contributor External developers NVIDIA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tom-Zheng @Xreki @onecatcn