Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Support TypeAttribute. #54984

Merged
merged 10 commits into from
Jul 2, 2023
Merged

[IR] Support TypeAttribute. #54984

merged 10 commits into from
Jul 2, 2023

Conversation

jiweibo
Copy link
Contributor

@jiweibo jiweibo commented Jun 29, 2023

PR types

Others

PR changes

Others

Description

Support TypeAttribute.

Others

Pcard-71500

@paddle-bot
Copy link

paddle-bot bot commented Jun 29, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jiweibo jiweibo requested a review from winter-wang June 29, 2023 06:38
@jiweibo jiweibo changed the title Pass sim [IR] Support TypeAttribute. Jun 29, 2023

DECLARE_ATTRIBUTE_UTILITY_FUNCTOR(TypeAttribute, TypeAttributeStorage);

Type GetValue() const;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


DECLARE_ATTRIBUTE_UTILITY_FUNCTOR(TypeAttribute, TypeAttributeStorage);

Type GetValue() const;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数名是不是直接叫value或者type或者data就可以了?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

winter-wang
winter-wang previously approved these changes Jun 29, 2023
Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiweibo jiweibo merged commit cc7d1f3 into PaddlePaddle:develop Jul 2, 2023
@jiweibo jiweibo deleted the pass_sim branch July 2, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants