Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CINN] Clarify cinn/ir dirs #55121

Merged
merged 10 commits into from
Jul 18, 2023
Merged

[CINN] Clarify cinn/ir dirs #55121

merged 10 commits into from
Jul 18, 2023

Conversation

JamesLim-sy
Copy link
Contributor

@JamesLim-sy JamesLim-sy commented Jul 4, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

Pcard-72675

  • Feature:
    Lots of files are directly placed in cinn/ir dir which does make cinn/ir dir a mess. This PR aims at improving structure of cinn/ir dir, enhancing its hierarchy.

  • Details:

    1. Set cinn/ir/schedule dir, move all schedule relevant files into it;
    2. Set cinn/ir/test dir, move all unittestt files into it;
    3. Set cinn/ir/utils dir, move utility files that derived from ir_base.h, such as ir_printer.h, ir_mutator into it;
    4. Set cinn/ir/op dir, move ir_operators.h file that records most of operator-override into it.

  • Result:
    By adopting this Pr, the structure of cinn/ir dir change from

    cinn/ir/
     ir_visitor.h
     ir_mutator.h
     ir_compare.h
     ir_operator.h
     ir_operator_test.cc
     ir_printer_test.cc
     ir_schedule.h
     ir_schedule_test.cc
     ir_base.h
     ir.h
     ...

    into

    cinn/ir/
    utils/
        ir_visitor.h
        ir_visitor.cc
        ir_mutator.h
        ir_mutator.cc
        ir_compare.h
        ir_compare.cc
         ...
    op/
        ir_operator.h
        ir_operator.cc
        ...
    schedule/
        ir_schedule.h
        ir_schedule.cc
        ir_schedule_error.h
        ir_schedule_error.cc
        ...
    test/
        ir_operator_test.cc
        ir_schedule_test.cc
        ...
    ir_base.h
    ir.h
    ...

@paddle-bot
Copy link

paddle-bot bot commented Jul 4, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@JamesLim-sy JamesLim-sy requested review from Xreki and Courtesy-Xs July 4, 2023 11:26
Courtesy-Xs
Courtesy-Xs approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@Courtesy-Xs Courtesy-Xs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BiynXu
BiynXu approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@BiynXu BiynXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZzSean
ZzSean approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhhsplendid
zhhsplendid approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raindrops2sea
raindrops2sea approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@raindrops2sea raindrops2sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesLim-sy JamesLim-sy merged commit 3624723 into PaddlePaddle:develop Jul 18, 2023
@JamesLim-sy JamesLim-sy changed the title Clarify cinn/ir dirs [Part1] [CINN] Clarify cinn/ir dirs Jul 18, 2023
cqulilujia pushed a commit to cqulilujia/Paddle that referenced this pull request Jul 24, 2023
@JamesLim-sy @cqulilujia
Clarify cinn/ir dirs [Part1] (PaddlePaddle#55121)
e4dc0d3 
* Clarify cinn/ir dirs [Part1]

* addition of cinn/ir/op dir

* change header inludsion of ir/ir_operator.h to ir/op/ir_operator.h

* merge with develop changes

* relocate libschedule_desc_proto.a

* remove extra ir_schedule_error.cc

* addition for schedule/ir_schedule_error files
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
@JamesLim-sy @wz1qqx
Clarify cinn/ir dirs [Part1] (PaddlePaddle#55121)
9b82fdb 
* Clarify cinn/ir dirs [Part1]

* addition of cinn/ir/op dir

* change header inludsion of ir/ir_operator.h to ir/op/ir_operator.h

* merge with develop changes

* relocate libschedule_desc_proto.a

* remove extra ir_schedule_error.cc

* addition for schedule/ir_schedule_error files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhhsplendid zhhsplendid zhhsplendid approved these changes

@Courtesy-Xs Courtesy-Xs Courtesy-Xs approved these changes

@ZzSean ZzSean ZzSean approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@BiynXu BiynXu BiynXu approved these changes

@Xreki Xreki Awaiting requested review from Xreki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JamesLim-sy @zhhsplendid @Courtesy-Xs @ZzSean @raindrops2sea @BiynXu