[NewIR] add stop_gradient attribute for defining op #55235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
winter-wang
reviewed
Jul 7, 2023
paddle/ir/core/operation.h
Outdated
| @@ -68,6 +68,14 @@ class IR_API alignas(8) Operation final { | |||
| attributes_[key] = value; | |||
| } | |||
|
|
|||
| Attribute GetAttribute(const std::string &key) const { | |||
There was a problem hiding this comment.
那其他两个接口需要换成set_attribute和has_attribute吗？
There was a problem hiding this comment.
可以顺便把SetAttribute接口也重命名为 set_attribute。
zhangbo9674
reviewed
Jul 7, 2023
paddle/ir/core/operation.h
Outdated
| @@ -68,6 +68,14 @@ class IR_API alignas(8) Operation final { | |||
| attributes_[key] = value; | |||
| } | |||
|
|
|||
| Attribute GetAttribute(const std::string &key) const { | |||
| return attributes_.at(key); | |||
There was a problem hiding this comment.
可以，我改成用ir_enforce判断一下吧，但是这样感觉和HasAttribute就有点重叠了。使用的时候一般要先用has_attribute判断，在这里再判断下就会判断两次。
There was a problem hiding this comment.
at好像已经带越界检查了。
但是at的报错提示不太友好
cqulilujia
pushed a commit
to cqulilujia/Paddle
that referenced
this pull request
Jul 24, 2023
* add stop_gradient attribute for defining op * modify by reviews * fix
wz1qqx
pushed a commit
to wz1qqx/Paddle
that referenced
this pull request
Jul 31, 2023
* add stop_gradient attribute for defining op * modify by reviews * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
After this op, the attribute
stop_attributeof VarDesc will be introduced as the attribute of the defining op of the corresponding value.The operation will be like:
However, it should be noted that not all operation will have a
stop_attributecurrently.Others
Pcard-67164