-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRIM][IR] Migrate vjp rules to new ir in non primitive mode #55647
Conversation
Nice work!! |
paddle/fluid/pybind/ir.cc
Outdated
j, | ||
vjp_res.size())); | ||
return res; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
该逻辑不要放到IR中
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
std::vector<std::vector<paddle::Tensor>> mean_vjp( | ||
const Tensor& x, | ||
const Tensor& out_grad, | ||
std::vector<int64_t> axis, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const IntArray&
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这儿会在下个pr修改成跟phi一致,后续需要做一层转换转到新ir下参数。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with TODO:fix comment problems in next pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
前向API 和 反向 API是不是分开两个文件合理些
587bea0
c155302
PR types
New features
PR changes
Others
Description
Pcard-66975
VJP规则与新IR打通(非组合模式)
1. 本PR主要完成的工作
2. 接下来需要完善功能
pd_op_vjp_manual.cc
合入pd_op.cc
进行代码自动生成, vjp模块中vjp.h
和vjp.cc
自动代码生成,backend模块中动静态图自动代码生成。3. 整体架构设计
4. 使用实例