Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fluid Clean] remove module fluid.layers.control_flow #55661

Merged
merged 6 commits into from
Jul 26, 2023

Conversation

zoooo0820
Copy link
Contributor

@zoooo0820 zoooo0820 commented Jul 24, 2023

PR types

Others

PR changes

APIs

Description

Pcard-67005

Remove all contents in python/paddle/fluid/layers/controw_flow

Func/Class are deleted :

  • Base Class of control flow (already have copies in paddle.static.nn.control_flow)
- BlockGuard
  • paddle.nn.static.StaticRNN and its correlation sub-function / class (use paddle.nn.RNN / paddle.nn.RNNCellBase for create object of RNN both in dynamic and static mode)
- StaticRNN
- StaticRNNMemoryLink
- BlockGuardWithCompletion
  • API While / while_loop and its correlation sub-function / class (already have copies in paddle.static.nn.control_flow)
- While
- WhileGuard
- get_inputs_outputs_in_block
- assign_skip_lod_tensor_array
- while_loop
- _deal_with_undefined_var
  • sub-functions called by static.nn.cond (already have copies in paddle.static.nn.control_flow)
- _to_sequence_except_dict
- _is_sequence_except_dict
- expand_undefined_var

Func/Class are moved to 2.0 (paddle.static) :

  • select_input/output (is part of paddle.static.nn.cond, offering control flow in static and dy2st)
- select_input_infer_shape
- select_input
- select_output
  • sub-class called by static.nn.cond
- ConditionalBlock
  • Switch and and its correlation sub-function / class ( called by piecewise_decay, which is offering LRDecay in static and dy2st)
- Switch
- ConditionalBlockGuard

@zoooo0820 zoooo0820 changed the title [Fluid Clean] remove api staticrnn [Fluid Clean] remove module fluid.layers.control_flow Jul 25, 2023
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
单测删除

Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 merged commit a646e75 into PaddlePaddle:develop Jul 26, 2023
@zoooo0820 zoooo0820 deleted the rm_staticRNN branch July 26, 2023 08:59
wz1qqx pushed a commit to wz1qqx/Paddle that referenced this pull request Jul 31, 2023
…5661)

* remove api staticrnn

* move select_input/output to static/controw flow

* delete some func, only remain Switch

* clean fluid.layers.controw_flow

* remove fluid.layers.controlflow

* fix conditional_block ut
jinjidejinmuyan pushed a commit to jinjidejinmuyan/Paddle that referenced this pull request Aug 30, 2023
…5661)

* remove api staticrnn

* move select_input/output to static/controw flow

* delete some func, only remain Switch

* clean fluid.layers.controw_flow

* remove fluid.layers.controlflow

* fix conditional_block ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants