[NewIR] support elementwise operations with axis!=-1 #55699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aurelius84
approved these changes
Jul 31, 2023
| "Expected op[%s]'s input X has only 1 variable, but got %d", | ||
| op_desc.Type(), | ||
| x_names.size()); | ||
| auto x_name = x_names[0]; |
There was a problem hiding this comment.
后续可以留意下auto的位置是否可以优先使用auto&，除了有copy的开销，更重要的是有时候可能会触发隐藏的bug（之前跟zhiqiu一起遇到过）
| ir::OpResult y_new; | ||
| if (std::find(y_shape.begin(), y_shape.end(), -1) == y_shape.end()) { | ||
| std::vector<int64_t> y_new_shape(y_shape); | ||
| for (int i = 0; i <= append_size; i++) { |
There was a problem hiding this comment.
Not Important，但++i好像更高效些，可以看下二者的区别
Suggested change
| for (int i = 0; i <= append_size; i++) { | |
| for (int i = 0; i <= append_size; ++i) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
close #55485
Others
Pcard-67164