Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fluid] move assign_pos to phi #55794

Merged
merged 6 commits into from
Aug 16, 2023
Merged

[Fluid] move assign_pos to phi #55794

merged 6 commits into from
Aug 16, 2023

Conversation

AndSonder
Copy link
Contributor

@AndSonder AndSonder commented Jul 28, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

将 assign_pos 迁移到 PHI 下

相关issue：

@paddle-bot
Copy link

paddle-bot bot commented Jul 28, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jul 28, 2023
@AndSonder AndSonder mentioned this pull request Jul 28, 2023
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 31, 2023
@luotao1
Copy link
Contributor

luotao1 commented Aug 1, 2023

windows流水线中单测没有过

@AndSonder
Copy link
Contributor Author

AndSonder commented Aug 2, 2023 •
edited
Loading

迁移之后PR-CI-CINN 单侧提示 test_group_norm_op 出现 diff，但是这个单测在线上V100 aistdio环境下是没问题的，还麻烦研发大哥看一下 ~ @GhostScreaming

image

@luotao1
Copy link
Contributor

luotao1 commented Aug 3, 2023

test_group_norm_op 这个单测在多个其他PR中均出现问题，在排查中，和本PR无关

@AndSonder
Copy link
Contributor Author

@GhostScreaming 麻烦Review一下~

@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Aug 7, 2023
@AndSonder
Copy link
Contributor Author

@hitywt 麻烦review一下 ~

GhostScreaming
GhostScreaming reviewed Aug 10, 2023
View reviewed changes
test/legacy_test/test_assign_pos_op.py
@@ -87,8 +87,9 @@ def setUp(self):
self.cum_count = cum_count

def test_forward(self):
paddle.enable_static()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥改成测静态图？

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndSonder

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review意见一直在pending，忘记点submit了...抱歉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个算子没有对应的python API，迁移之后会报类似下面的这个错误，所以这里就改成只测试静态图的了：

image

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Aug 10, 2023

Sorry to inform you that efb5251's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@hitywt
Copy link

hitywt commented Aug 12, 2023

PR-CI-Model-benchmark

PR-CI-Model-benchmark这个需要re-run一下看看

@AndSonder
Copy link
Contributor Author

PR-CI-Model-benchmark

PR-CI-Model-benchmark这个需要re-run一下看看

需要帮忙rerun一下，这边提示我没有权限

image

@luotao1
Copy link
Contributor

luotao1 commented Aug 15, 2023

@AndSonder PR-CI-Model-benchmark rerun多次依然失败，可以merge下develop试下

@AndSonder
Copy link
Contributor Author

@AndSonder PR-CI-Model-benchmark rerun多次依然失败，可以merge下develop试下

好的

GhostScreaming
GhostScreaming approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@GhostScreaming GhostScreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 9d89927 into PaddlePaddle:develop Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhostScreaming GhostScreaming GhostScreaming approved these changes

@luotao1 luotao1 luotao1 approved these changes

Assignees

@hitywt hitywt

@luotao1 luotao1

@GhostScreaming GhostScreaming

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndSonder @luotao1 @hitywt @GhostScreaming