Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

赛题五:将 xdoctest 引入到飞桨框架工作流中 #55899

Closed
wants to merge 2 commits into from

Conversation

yuchen202
Copy link
Contributor

@yuchen202 yuchen202 commented Aug 2, 2023

【队名】:不想画图
【序号】:赛题五:将 xdoctest 引入到飞桨框架工作流中
【状态】:报名 & 提交RFC
【链接】:#55899

@paddle-bot
Copy link

paddle-bot bot commented Aug 2, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 2, 2023
@paddle-bot
Copy link

paddle-bot bot commented Aug 2, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@luotao1
Copy link
Contributor

luotao1 commented Aug 2, 2023

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 2, 2023
@SigureMo
Copy link
Member

SigureMo commented Aug 2, 2023

#55629 (comment) 点击「提交 PR」里面有模板

>>> x = paddle.to_tensor([[-1., 6.], [1., 15.6]])
>>> out = F.celu(x, alpha=0.2)
[[-0.19865242, 6. ],
[ 1. , 15.60000038]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

输出要与 >>> 对齐

>>> [6.0, 7.0, 8.0, 9.0]]],dtype='float32')
>>> out1 = F.softmax(x)
>>> out2 = F.softmax(x, dtype='float64')
out1's data type is float32; out2's data type is float64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

非输出的不要放在这里,要在代码里进行 print,然后利用输出或者 assert 检查这些,比如

>>> assert out1.dtype == paddle.float32
>>> assert out2.dtype == paddle.float64

@megemini dtype 的 repr 不太好看,这里我觉得 assert 更好,你觉得呢?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以及,不是简单地解开注释就行了,仔细看一遍文档吧,很多要点都没做

@SigureMo
Copy link
Member

SigureMo commented Aug 3, 2023

以及 PR 描述还没修改

@yuchen202
Copy link
Contributor Author

@SigureMo
Copy link
Member

SigureMo commented Aug 3, 2023

应该在这里,#55933 (comment)

新的 PR 有同样的问题,也需要修改

以及,如果这个不需要的话,就 close 吧

@paddle-bot
Copy link

paddle-bot bot commented Aug 3, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants