Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move some fluid apis #55986

Merged
merged 7 commits into from
Aug 11, 2023
Merged

move some fluid apis #55986

merged 7 commits into from
Aug 11, 2023

Conversation

Difers
Copy link
Contributor

@Difers Difers commented Aug 4, 2023

PR types

Others

PR changes

APIs

Description

非底层概念的公开API迁移到2.0

@paddle-bot
Copy link

paddle-bot bot commented Aug 4, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 4, 2023
@Difers Difers force-pushed the replac_fluid_opt branch 3 times, most recently from 3b45a63 to f4222ef Compare August 5, 2023 11:34
@@ -55,60 +55,4 @@
from paddle import _C_ops, _legacy_C_ops
from collections.abc import Iterable


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件没内容了,直接删掉

@@ -492,7 +491,6 @@
'logcumsumexp',
'logit',
'logit_',
'LazyGuard',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

探索下解决方案,不能直接删除现有公开API

@@ -37,6 +45,14 @@
'MultiplicativeDecay',
'OneCycleLR',
'CyclicLR',
'exponential_decay',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个新增过来的不属于公开API,不在__all__列表里添加

@Difers Difers force-pushed the replac_fluid_opt branch 3 times, most recently from 27be22c to b7d6e27 Compare August 7, 2023 11:13
Copy link
Contributor

@zoooo0820 zoooo0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Difers Difers force-pushed the replac_fluid_opt branch 2 times, most recently from b149f6a to 41b2e3e Compare August 9, 2023 07:09
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自查一下吧,是否迁移后的代码示例还存在使用 fluid 的情况


paddle.enable_static()
base_lr = 0.1
sgd_optimizer = fluid.optimizer.SGD(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

诸如此类,迁移后的代码,使用的还是 fluid 路径,请修改一下~


.. code-block:: python

import paddle.fluid as fluid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import fluid 是一定需要的吗?

Examples:
.. code-block:: python

import paddle.fluid as fluid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上,出现fluid,请修改

Examples:
.. code-block:: python

import paddle.fluid as fluid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上,出现fluid,请修改


.. code-block:: python

import paddle.fluid as fluid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上,出现fluid,请修改

@Difers
Copy link
Contributor Author

Difers commented Aug 14, 2023

自查一下吧,是否迁移后的代码示例还存在使用 fluid 的情况

收到

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants