Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4637
cudnn_helper.h
can be used to process 3D data directly. I only addkNCDHW
element and change it's unit test.class DataLayout
are not used in current code.pool3d_cudnn_op
and unit test.cudnnSetTensorNdDescriptor
andcudnnSetTensor4dDescriptor
), but the current understanding is thatcudnnSetTensorNdDescriptor
can replacecudnnSetTensor4dDescriptor
, and because it is only aDescriptor
, so it is possible that the efficiency of influence is not large (or even negligible).I'll get a better understanding of the difference between them. If someone know that, please tell me, thx.