Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the optimizer base and learning rate base #56099

Merged
merged 4 commits into from
Aug 11, 2023
Merged

remove the optimizer base and learning rate base #56099

merged 4 commits into from
Aug 11, 2023

Conversation

longranger2
Copy link
Contributor

PR types

Others

PR changes

APIs

Description

remove the optimizer base and learning rate base in fluid

@paddle-bot
Copy link

paddle-bot bot commented Aug 9, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Aug 9, 2023
zoooo0820
zoooo0820 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@zoooo0820 zoooo0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeff41404
jeff41404 previously approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Aug 11, 2023

请解决下冲突

sunzhongkai588
sunzhongkai588 approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 merged commit 6eaed2d into PaddlePaddle:develop Aug 11, 2023
@longranger2 longranger2 mentioned this pull request Aug 27, 2023
Closed
@longranger2 longranger2 deleted the optimizer_base branch September 13, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

@zoooo0820 zoooo0820 zoooo0820 approved these changes

@jeff41404 jeff41404 jeff41404 approved these changes

Assignees
No one assigned
Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@longranger2 @luotao1 @jeff41404 @zoooo0820 @sunzhongkai588