Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move c_identity to phi #56215

Merged
merged 8 commits into from
Aug 23, 2023
Merged

move c_identity to phi #56215

merged 8 commits into from
Aug 23, 2023

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Aug 12, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

move c_identity to phi

@paddle-bot paddle-bot bot added the contributor External developers label Aug 12, 2023
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Aug 14, 2023
@luotao1 luotao1 mentioned this pull request Aug 14, 2023
Closed
@luotao1
Copy link
Contributor

luotao1 commented Aug 16, 2023

请解决下冲突

@GreatV
Copy link
Contributor Author

GreatV commented Aug 20, 2023

@GhostScreaming 这个可以Review一下了

GhostScreaming
GhostScreaming approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@GhostScreaming GhostScreaming left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修复一下PR-CI-APPROVAL的问题，custom_device_common_op_registry.cc应该使用phi::DeviceContext::Alloc()或者 phi::DeviceContext::HostAlloc()，不调用DenseTensor::mutable_data()

@GreatV
Copy link
Contributor Author

GreatV commented Aug 23, 2023

修复一下PR-CI-APPROVAL的问题，custom_device_common_op_registry.cc应该使用phi::DeviceContext::Alloc()或者 phi::DeviceContext::HostAlloc()，不调用DenseTensor::mutable_data()

Done.

@GreatV GreatV requested a review from GhostScreaming August 23, 2023 00:21
GhostScreaming
GhostScreaming approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@GhostScreaming GhostScreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 9ed58bf into PaddlePaddle:develop Aug 23, 2023
@GreatV GreatV deleted the move_c_identity_to_phi branch August 23, 2023 09:08
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@GreatV @BeingGod
move c_identity to phi (PaddlePaddle#56215)
9c266d9
@GreatV GreatV mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhostScreaming GhostScreaming GhostScreaming approved these changes

@luotao1 luotao1 luotao1 approved these changes

Assignees

@hitywt hitywt

@luotao1 luotao1

@GhostScreaming GhostScreaming

Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GreatV @luotao1 @GhostScreaming @hitywt