Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CustomDevice] add comm context support #56301

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[CustomDevice] add comm context support #56301

merged 1 commit into from
Aug 25, 2023

Conversation

ronny1996
Copy link
Contributor

@ronny1996 ronny1996 commented Aug 15, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

add comm context support

NPU 上 API 验证通过
image

@paddle-bot
Copy link

paddle-bot bot commented Aug 15, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ronny1996 ronny1996 force-pushed the custom_comm_context branch 13 times, most recently from 576b7d8 to 6180b04 Compare August 16, 2023 09:16
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Aug 24, 2023

Sorry to inform you that 6180b04's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@ronny1996 ronny1996 force-pushed the custom_comm_context branch from 6180b04 to 99dede9 Compare August 24, 2023 10:39
qili93
qili93 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hitywt
hitywt approved these changes Aug 25, 2023
View reviewed changes
Copy link

@hitywt hitywt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronny1996 ronny1996 merged commit 62397cd into PaddlePaddle:develop Aug 25, 2023
@ronny1996 ronny1996 deleted the custom_comm_context branch August 25, 2023 06:30
@jinmingyi1998
Copy link
Contributor

jinmingyi1998 commented Aug 25, 2023 •
edited
Loading

@ronny1996
I got error:

https://github.com/PaddlePaddle/Paddle/blame/develop/paddle/phi/core/distributed/comm_context_manager.cc#L115

paddle/phi/core/distributed/comm_context_manager.cc:115:3: error: ‘VLOG’ was not declared in this scope
  115 |   VLOG(3) << "init xccl rank: " << rank << ", nranks: " << size
      |   ^~~~

@engineer1109 engineer1109 mentioned this pull request Aug 29, 2023
Closed
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
@ronny1996 @BeingGod
[CustomDevice] add comm context support (PaddlePaddle#56301)
7bf0971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@qili93 qili93 qili93 approved these changes

@hitywt hitywt hitywt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronny1996 @jinmingyi1998 @hitywt @qili93 @XiaoguangHu01