Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NewIR] Insert get_parameter only for paramters #56325

Merged
merged 3 commits into from
Aug 16, 2023
Merged

[NewIR] Insert get_parameter only for paramters #56325

merged 3 commits into from
Aug 16, 2023

Conversation

kangguangli
Copy link
Contributor

@kangguangli kangguangli commented Aug 15, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

  1. Strength the requirements for insert a builtin.get_parameter , now only insert for real parameters
  2. For variables created by paddle.static.data or other apis, a pd.data should be inserted instead. For compatibility, we modify the api of paddle.static.data when flag FLAGS_enable_new_ir_in_executor is set.

Others

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Aug 15, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

wanghuancoder
wanghuancoder approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyber-pioneer
Copy link
Contributor

Lack for description of pr?

@kangguangli
Copy link
Contributor Author

Lack for description of pr?

Done

@kangguangli kangguangli merged commit 0f611f1 into PaddlePaddle:develop Aug 16, 2023
@kangguangli kangguangli deleted the fix_program_translator branch August 16, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyber-pioneer cyber-pioneer cyber-pioneer approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

@Charles-hit Charles-hit Charles-hit approved these changes

@wanghuancoder wanghuancoder wanghuancoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kangguangli @cyber-pioneer @wanghuancoder @Charles-hit @zhangbo9674