Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] add block operand support for ir. #56354

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

winter-wang
Copy link
Contributor

@winter-wang winter-wang commented Aug 16, 2023

PR types

New features

PR changes

Others

Description

新IR增加对OpOperand的支持。

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Aug 16, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@winter-wang winter-wang force-pushed the ir_develop_2 branch 18 times, most recently from 2b3945c to cc2252b Compare August 24, 2023 09:31
Copy link
Contributor

@kangguangli kangguangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是得增加下对printer的适配?

@winter-wang
Copy link
Contributor Author

@winter-wang
Copy link
Contributor Author

winter-wang commented Aug 27, 2023

是不是得增加下对printer的适配?

我觉得应该不需要。拥有BlockOperand的算子都可以认为是一种特殊的算子,它应该有自定义的Printer,由算子开发者来定义相应的格式。

@winter-wang winter-wang reopened this Aug 27, 2023
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winter-wang winter-wang merged commit 662df29 into PaddlePaddle:develop Aug 28, 2023
lxd-cumt pushed a commit to lxd-cumt/Paddle that referenced this pull request Aug 28, 2023
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants