Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NewIR] Add shapedtype interface #56427

Merged
merged 22 commits into from
Sep 12, 2023
Merged

[NewIR] Add shapedtype interface #56427

merged 22 commits into from
Sep 12, 2023

Conversation

zhangbopd
Copy link
Contributor

@zhangbopd zhangbopd commented Aug 18, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

  • 添加 Type Interface
  • 添加 ShapedType Interface
  • 添加相关单测

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Aug 18, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhangbopd zhangbopd marked this pull request as draft August 23, 2023 11:39
@zhangbopd zhangbopd marked this pull request as ready for review August 23, 2023 11:40
@zhangbopd zhangbopd requested review from winter-wang, zhangbo9674, Aurelius84 and phlrain and removed request for winter-wang September 6, 2023 13:55
winter-wang
winter-wang reviewed Sep 7, 2023
View reviewed changes
paddle/ir/core/type.h Outdated Show resolved Hide resolved
winter-wang
winter-wang reviewed Sep 7, 2023
View reviewed changes
paddle/ir/core/type.h Outdated Show resolved Hide resolved
winter-wang
winter-wang reviewed Sep 7, 2023
View reviewed changes
paddle/ir/core/type.h Outdated Show resolved Hide resolved
winter-wang
winter-wang reviewed Sep 7, 2023
View reviewed changes
paddle/ir/core/type.h Outdated Show resolved Hide resolved
winter-wang
winter-wang reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议补充Type到TypeInterface的 dyn_cast接口的正反测试。

zhangbo9674
zhangbo9674 reviewed Sep 7, 2023
View reviewed changes
paddle/ir/core/type_base.cc Outdated Show resolved Hide resolved
paddle/ir/core/type_base.cc Outdated Show resolved Hide resolved
zhangbo9674
zhangbo9674 reviewed Sep 7, 2023
View reviewed changes
paddle/ir/core/type.h Outdated Show resolved Hide resolved
paddle/ir/core/storage_manager_support.h Outdated Show resolved Hide resolved
paddle/ir/core/builtin_type_interfaces.h Outdated Show resolved Hide resolved
@zhangbopd
Copy link
Contributor Author

建议补充Type到TypeInterface的 dyn_cast接口的正反测试。

done 已经补充到单测中

@Aurelius84 Aurelius84 changed the title add shapedtype interface [NewIR] Add shapedtype interface Sep 12, 2023
@zhangbopd zhangbopd merged commit 3d8f97d into PaddlePaddle:develop Sep 12, 2023
@zhangbopd zhangbopd deleted the type_interface branch September 12, 2023 05:38
@PaddlePaddle PaddlePaddle deleted a comment from winter-wang Sep 12, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@zhangbopd
[NewIR] Add shapedtype interface (PaddlePaddle#56427)
e6938c6 
* add shapedtype interface

* add storage_manager_support

* delete DECLARE_TYPE_UTILITY_FUNCTOR

* split interfaceValue

* add dyn_cast_interface

* add unit_test

* change cast utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winter-wang winter-wang winter-wang left review comments

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@phlrain phlrain Awaiting requested review from phlrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangbopd @Aurelius84 @raindrops2sea @winter-wang @zhangbo9674