Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewIR] register set_value in new ir #56436

Merged
merged 17 commits into from
Aug 28, 2023

Conversation

kangguangli
Copy link
Contributor

PR types

Others

PR changes

Others

Description

Others

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Aug 18, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

YuanRisheng
YuanRisheng previously approved these changes Aug 24, 2023
paddle/phi/infermeta/backward.cc Show resolved Hide resolved
zhangbo9674
zhangbo9674 previously approved these changes Aug 24, 2023
Aurelius84
Aurelius84 previously approved these changes Aug 24, 2023
paddle/fluid/ir/dialect/paddle_dialect/ir/pd_op.yaml Outdated Show resolved Hide resolved
func: [set_value]
param: [x, starts, ends, steps, axes, decrease_axes, none_axes, shape, values]
inplace: null
backward: set_value_grad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_value_grad的参数和这个好像对不上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是对不上,它们的kernel也不一致

Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for YAML

@kangguangli kangguangli merged commit deee91d into PaddlePaddle:develop Aug 28, 2023
@kangguangli kangguangli deleted the add_set_value branch August 28, 2023 02:47
BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023
* register set_value in new ir

* fix

* register set_value_grad

* fix

* fix

* remove debug info

* add unittest

* fix

* fix

* fix

* fix

* fix

* resolve comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants