Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve value-src dtype fault #56613

Merged

Conversation

zoooo0820
Copy link
Contributor

@zoooo0820 zoooo0820 commented Aug 24, 2023

PR types

Bug fixes

PR changes

APIs

Description

Pcard-66985

Support case in __setitem__ when dtype of src and value are not same.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Sep 7, 2023

Sorry to inform you that b803b41's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@zoooo0820 zoooo0820 force-pushed the fix_value_src_dtype_error_in_setitem branch from 12ae53d to 02fa379 Compare September 11, 2023 06:26
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff41404 jeff41404 merged commit 594177b into PaddlePaddle:develop Sep 14, 2023
@zoooo0820 zoooo0820 deleted the fix_value_src_dtype_error_in_setitem branch September 14, 2023 10:27
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* solve value-src dtype fault

* support basic-indexing with different dtype, add UT

* skip amp convert when level is O0

* fix ut of amp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants