Add elementwise_add into Paddle-TRT NHWC support #56795
Merged
+26
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
Hi，感谢您提交此优化PR，对于您在PR描述里说的 Before : transpose -> conv2d -> (transpose -> transpose) -> batch_norm -> transpose -> relu -> transpose -> conv2d -> transpose，我理解应该不是这样子，应该是 Before : transpose -> conv2d -> batch_norm -> relu -> conv2d -> transpose。这个PR下还麻烦您补充下单测，通过手动组网保存模型后测试并贴出pass转化前后的graph看一下，谢谢。我会持续关注此PR。 |
yuanlehome
reviewed
Aug 30, 2023
leo0519
changed the title
|
Hi @yuanlehome , 後來發現是因為 elementwise_add 不在白名單內 (需求模型為 ResNet50)，因此修改本 PR 的標題和敘述，再麻煩你 review 一下，謝謝。 |
heavengate
approved these changes
Aug 31, 2023
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
* Add elementwise_add support into NHWC IR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
For NHWC ResNet50 model, there are several
elementwise_addOPs, but Paddle-TRT NHWC IR pass does not support these OP.This PR adds
elementwise_addsupport into NHWC IR pass, and also updates the unit test.