-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend matmul_int8 and support matmul_with_flatten_int8 #56827
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
✅ This PR's description meets the template requirements! |
@@ -43,3 +43,9 @@ PD_REGISTER_KERNEL(matmul_with_flatten, | |||
double, | |||
phi::dtype::bfloat16, | |||
phi::dtype::float16) {} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
期望不使用matmul_int8和matmul_with_flatten_int8独立于 matmul和matmul_with_flatten,而是通过增加数据类型的方式支持。之前的matmul_int8是一种非常临时的方式
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前修改了这个部分,按照上述这个方式进行了实现。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
|
||
#if defined(PADDLE_WITH_CUDA) | ||
#if CUDA_VERSION >= 11060 | ||
REGISTER_OP_CUDA_KERNEL( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个op已经废弃了吧,还需要更新它的实现吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
动转静之后仍然走了这里的实现
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for unittest.skip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for check dygraph = false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…)" This reverts commit 5b6594c.
…#56827) * add matmul_int8 and matmul_with_flatten_int8 * fix api of int8 matmul and matmul_with_flatten * support dy2static * fix static matmul build * code refine * add cuda version limitation in matmulflatten * avoid rocm build error * fix build error * fix build errors: auto_tune and blaslt_impl * fix inference ci error * fix multidefinition error * fix matmul with flatten error * fix unit test --------- Co-authored-by: RichardWooSJTU <37864677+RichardWooSJTU@users.noreply.github.com> Co-authored-by: wufeisheng <wfs1997@163.com>
PR types
New features
PR changes
Ops
Description