Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify compare logical inplace #56888

Merged

Conversation

GGBond8488
Copy link
Contributor

@GGBond8488 GGBond8488 commented Sep 1, 2023

PR types

Others

PR changes

OPs

Description

Pcard-75099
set compare and logcial out dtype bool

@paddle-bot
Copy link

paddle-bot bot commented Sep 1, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@GGBond8488 GGBond8488 closed this Sep 4, 2023
@GGBond8488 GGBond8488 reopened this Sep 4, 2023
@GGBond8488 GGBond8488 marked this pull request as draft September 4, 2023 08:15
@GGBond8488 GGBond8488 marked this pull request as ready for review September 5, 2023 02:36
@GGBond8488 GGBond8488 marked this pull request as draft September 5, 2023 02:37
@GGBond8488 GGBond8488 marked this pull request as ready for review September 5, 2023 02:37
Comment on lines 41 to 44
void InplaceLogicalKnernelImpl(const Context& dev_ctx,
const DenseTensor& x,
const DenseTensor& y,
DenseTensor* out) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why create InplaceLogicalKnernelImpl here while not create in logical_kernel.cc, can we integrate code of LogicalKnernelImpl and InplaceLogicalKnernelImpl into Logical##type##Kernel to maintain the same form as logical_kernel.cc

@GGBond8488 GGBond8488 closed this Sep 11, 2023
@GGBond8488 GGBond8488 reopened this Sep 11, 2023
@GGBond8488 GGBond8488 marked this pull request as draft September 11, 2023 07:49
@GGBond8488 GGBond8488 marked this pull request as ready for review September 11, 2023 07:49
@jeff41404 jeff41404 merged commit b02a42c into PaddlePaddle:develop Sep 13, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* fix error

* fix compare

* fix

* fix

* remove fluid

* fix inpalce test

* fix and sep inpalce impl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants