-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify compare logical inplace #56888
Modify compare logical inplace #56888
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
… modify_compare_logical_inplace
void InplaceLogicalKnernelImpl(const Context& dev_ctx, | ||
const DenseTensor& x, | ||
const DenseTensor& y, | ||
DenseTensor* out) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why create InplaceLogicalKnernelImpl
here while not create in logical_kernel.cc
, can we integrate code of LogicalKnernelImpl
and InplaceLogicalKnernelImpl
into Logical##type##Kernel
to maintain the same form as logical_kernel.cc
… modify_compare_logical_inplace
… modify_compare_logical_inplace
* fix error * fix compare * fix * fix * remove fluid * fix inpalce test * fix and sep inpalce impl
PR types
Others
PR changes
OPs
Description
Pcard-75099
set compare and logcial out dtype bool