Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cos_sim_op in debug mode. #5707

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Fix cos_sim_op in debug mode. #5707

merged 1 commit into from
Nov 16, 2017
+1 −1

Conversation

qingqing01
Copy link
Contributor

@qingqing01 qingqing01 commented Nov 16, 2017 •
edited
Loading

Fix #5706

Also related to #5559

pkuyym
pkuyym approved these changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@pkuyym pkuyym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingqing01 qingqing01 merged commit 9cf6036 into PaddlePaddle:develop Nov 16, 2017
@qingqing01 qingqing01 deleted the cos_sim_op branch March 7, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkuyym pkuyym pkuyym approved these changes

@dzhwinter dzhwinter Awaiting requested review from dzhwinter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qingqing01 @pkuyym