[CodeStyle] update ruff v0.0.289 and black 23.9.1 #57145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Sep 9, 2023
| # "PLR1701", | ||
| # "PLR1711", # Confirmation required | ||
| "PLR1722", | ||
| # "PLW3301", # Confirmation required |
SigureMo
reviewed
Sep 11, 2023
| @@ -40,6 +39,7 @@ select = [ | |||
|
|
|||
| # NumPy-specific rules | |||
| "NPY001", | |||
| # "NPY003", | |||
There was a problem hiding this comment.
# 本 rule 自动修复方案不合适，因此仅仅跑一下（不加 `--fix`），之后手动修复 ruff --select NPY003 .
NPY003 不适合自动修复么？我随便看了下感觉自动修复效果还可以呀
如果不适合的话，之后需要放到 unfixable 里
|
Description 里加一下本 PR 改动了什么的说明吧 |
Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
SigureMo
changed the title
…python/paddle/base
gouzil
changed the title
gouzil
changed the title
gouzil
changed the title
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…#57145) * [CodeStyle][ruff] update ruff v0.0.287 * add NPY003 * Update setup.py Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com> * update 288 * update ruff to v0.0.289; update black to 23.9.1; flake8 split ignore python/paddle/base * fix ignore * split flake8 --------- Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
此 PR 工作: 升级
ruff至 v0.0.289 并新增检查, 重新打开PLR1722检查. 由于新版本检查更为严格, 所以在pyproject.toml单独 ignore 文件(后续修复). 同时 ignore./python/paddle/base/**为后续引入做准备.第一阶段
存量统计
升级
ruff至 v0.0.289 并新增检查存量 tracking issue
新增
第二阶段
ruff
删除
ignore中的./python/paddle/base/**选项的错误码, 并修复已存在的所有检查flake8
删除
per-file-ignores中的# tmp ignore下对应的错误码, 并修复已存在的所有检查相关文档
常用命令