Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewIR] support symbol overload #57164

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

cyber-pioneer
Copy link
Contributor

@cyber-pioneer cyber-pioneer commented Sep 10, 2023

PR types

New features

PR changes

Others

Description

Pcard-66975
Support Opresult symbol overload: +(add), -(subtract) , *(multiply), /(divide) ,-(scale)

@paddle-bot
Copy link

paddle-bot bot commented Sep 10, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@cyber-pioneer cyber-pioneer changed the title add symbol overload [NewIR] support symbol overload Sep 12, 2023
.def("__truediv__",
[](OpResult &self, OpResult &other) {
return paddle::dialect::divide(self, other);
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

比较类运算符是否也需要

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后续可以添上

zhangbo9674
zhangbo9674 previously approved these changes Sep 12, 2023
@cyber-pioneer cyber-pioneer merged commit 944d18e into PaddlePaddle:develop Sep 12, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* add symbol overload

* add test case

* fix code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants