[CINN] add compile error handler #57198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZzSean
reviewed
Sep 15, 2023
paddle/cinn/backends/compiler.cc
Outdated
| std::stringstream content; | ||
| content << info_.lowered_funcs[idx].front(); | ||
| if (info_.Status(idx) > hlir::framework::CompilationStatus::LOWERING_FAIL) { |
There was a problem hiding this comment.
hlir::framework::CompilationStatus::LOWERING_FAIL可以用using缩短一下，下同
ZzSean
reviewed
Sep 15, 2023
| std::ostringstream os; | ||
| os << "[CompileError] An error occurred during compilation with the error " | ||
| "code: " | ||
| << utils::Enum2String(status_) << std::endl; |
There was a problem hiding this comment.
我看了下Enum2String的实现，还挺复杂的，如果只是为了把enum转成相应的string，是不是可以简化一下实现，还是说有其他的考虑
There was a problem hiding this comment.
该实现可以支持任意枚举类转为String，未来若有其他需求可以复用，无需每个枚举类自己定义ToString().
ZzSean
reviewed
Sep 15, 2023
| std::vector<std::optional<std::string>> source_ptxs_; | ||
| std::vector<std::unique_ptr<Instruction>> instructions_; | ||
| std::unique_ptr<Program> runtime_program_; | ||
| uint size_; |
There was a problem hiding this comment.
uint好像不是C++中的常规数据类型，可能会被编译器识别为unsigned int，可以正常使用，但还是建议换种写法
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* [CINN] add compile error handler * [Fix] cinn_compiler return value * Refine code style
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* [CINN] add compile error handler * [Fix] cinn_compiler return value * Refine code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-73602
Add CompileErrorHandler.
Replace some CHECKs in GraphCompile and improve error messages.
Make data members of CompilationResult private.