【NewIR】modify static_op_function vector mutable attr bug (Split op ) #57218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dev/refine_mutable_attr_split
|
你的PR提交成功，感谢你对开源项目的贡献! |
YuanRisheng
previously approved these changes
Sep 14, 2023
| @@ -132,19 +132,29 @@ def _gen_api_inputs(self, op_info): | |||
| ret.append(f'{self._type_map[type]} {name}') | |||
| return ', '.join(ret) | |||
|
|
|||
| def _gen_api_attrs(self, op_info, with_default, is_mutable_attr): | |||
| def _gen_api_attrs( | |||
| self, op_info, with_default, is_mutable_attr, is_vector_mutable_sttr | |||
There was a problem hiding this comment.
is_vector_mutable_sttr -> is_vector_mutable_attr
| mutable_attr.append(f'{OP_RESULT} {name}') | ||
| if ( | ||
| mutable_type_list[mutable_name_list.index(name)][0] | ||
| == "paddle::dialect::IntArrayAttribute" |
There was a problem hiding this comment.
发现该pr有大量这样的写法，可以把"paddle::dialect::IntArrayAttribute"抽出来变成全局变量，或者是封装成函数，避免硬编码
|
|
0x45f
reviewed
Sep 14, 2023
| @@ -132,19 +132,29 @@ def _gen_api_inputs(self, op_info): | |||
| ret.append(f'{self._type_map[type]} {name}') | |||
| return ', '.join(ret) | |||
|
|
|||
| def _gen_api_attrs(self, op_info, with_default, is_mutable_attr): | |||
| def _gen_api_attrs( | |||
| self, op_info, with_default, is_mutable_attr, is_vector_mutable_sttr | |||
paddle/fluid/pybind/eager_utils.cc
Outdated
| @@ -138,6 +138,25 @@ bool PyObject_CheckIROpResult(PyObject* obj) { | |||
| return PyObject_TypeCheck(obj, g_ir_opresult_pytype); | |||
| } | |||
|
|
|||
| bool PyObject_CheckIRVectorOfOpResult(PyObject* obj) { | |||
| if (PyList_Check(obj)) { | |||
paddle/fluid/pybind/eager_utils.cc
Outdated
| } | ||
| for (Py_ssize_t i = 0; i < len; i++) { | ||
| item = PyList_GetItem(obj, i); | ||
| if (!PyObject_CheckIROpResult(item)) { |
There was a problem hiding this comment.
现在可以处理python端传过来的[1, OpResult, 2]这样int和OpResult混合的list吗？
This was referenced Sep 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
others
Description
pcard-67164
修改python-c 接口代码，将可变attribute 在python-c层全部转为opreslut 传递给pd_api 接口。由于一个op可能有多个可变attribute，无法限制用户全部使用同一形式传参，而支持各个组合会使代码分支增多，因此统一处理为输入形式。
修改前生成代码为
同时，若vector 类型的attrbute 以input输入，pd_api.h 提供的接口应该为 std::vector<ir::OpResult >形式； 但static_op_function调用形式为 OpResult， 因此生成两种可变attribute input 形式的接口,加attr 形式接口共三个。
2.split python api 适配
3.ir_backward 修复full 无法创建空shape，-1shape opreslut 问题
此pr 拆解为 #57281 #57333 comments 回复#57354