Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR] standardize the use of value[-1]. #57349

Merged
merged 1 commit into from
Sep 15, 2023
Merged

[PIR] standardize the use of value[-1]. #57349

merged 1 commit into from
Sep 15, 2023

Conversation

winter-wang
Copy link
Contributor

@winter-wang winter-wang commented Sep 14, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

规范化代码中对Value的使用[-1]。

Value分两种，OpResult和BlockArgument. 由于之前没有BlockArgument， 大家都是混用Value和OpResult， 现在有了BlockArguemnt, 需要区分Value和OpResult的使用。

本pr内容：

  • 将pri::Operation::Create接口中的输入参数由std::vector<pir::OpResult>修改为std::vector<pir::value>。
    并同步修改了对pir::Operation::Create接口的调用。
  • 将shape dialect中相关op的Build接口的相关参数由OpResult替换成了Value。

Todo:

  • 将pir::OperationArgument::inputs_中的类型由std::vector<pir::OpResult>修改为std::vector<pir::value>。
  • 将其它Dialect中相关op的Build接口的相关参数由OpResult替换成了Value。

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Sep 14, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@winter-wang winter-wang force-pushed the ir_develop_2 branch 15 times, most recently from 5b9a9be to 1dadf8f Compare September 15, 2023 04:52
@winter-wang winter-wang changed the title [PIR] normalize the use of value. [PIR] normalize the use of value. 3-1. Sep 15, 2023
liuruyan
liuruyan approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@liuruyan liuruyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ShapeDialect.

zhangbo9674
zhangbo9674 previously approved these changes Sep 15, 2023
View reviewed changes
@winter-wang winter-wang merged commit ac77cff into PaddlePaddle:develop Sep 15, 2023
@winter-wang winter-wang changed the title [PIR] normalize the use of value. 3-1. [PIR] normalize the use of value. 4-1. Sep 16, 2023
@winter-wang winter-wang mentioned this pull request Sep 16, 2023
Merged
@winter-wang winter-wang changed the title [PIR] normalize the use of value. 4-1. [PIR] standardize the use of value. 4-1. Sep 16, 2023
This was referenced Sep 17, 2023
Merged
Merged
Merged
@winter-wang winter-wang changed the title [PIR] standardize the use of value. 4-1. [PIR] standardize the use of value[-1]. Sep 18, 2023
@winter-wang winter-wang mentioned this pull request Sep 19, 2023
Merged
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@winter-wang
[PIR] normalize the use of value. (PaddlePaddle#57349)
dad1c8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuruyan liuruyan liuruyan approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

@Aurelius84 Aurelius84 Awaiting requested review from Aurelius84

@zhangbopd zhangbopd Awaiting requested review from zhangbopd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winter-wang @liuruyan @zhangbo9674