Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle] [task 10] and [task 21] enable Ruff B017 and C405 rule in python/paddle/base #57377

Closed
wants to merge 2 commits into from

Conversation

yuchen202
Copy link
Contributor

@yuchen202 yuchen202 commented Sep 15, 2023

PR types

Others

PR changes

Others

Description

哥们真不会改,照着自己的理解改了改。有啥问题还请多多指正。

@paddle-bot
Copy link

paddle-bot bot commented Sep 15, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 15, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 15, 2023
@gouzil
Copy link
Member

gouzil commented Sep 17, 2023

B017需要单独看一下是什么错误类型的,基本上都是需要手动修复的,可以参考一下上期的pr #52553

C405比较简单也可以参考一下上期的pr #51972

建议一个错误码一个pr,有问题也可以群里直接问

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Sep 23, 2023

Sorry to inform you that e273418's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

发现原来要切换路径。。。
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果不会做 B017 这个 PR 就单独做 C405

@yuchen202
Copy link
Contributor Author

如果不会做 B017 这个 PR 就单独做 C405

B017是真不会做

@luotao1
Copy link
Contributor

luotao1 commented Oct 17, 2023

@enkilee 敏师傅可以看下任务10

@luotao1 luotao1 closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants