Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][task 17] enable Ruff F811 rule in python/paddle/base #57398

Merged
merged 1 commit into from
Sep 16, 2023
Merged

[CodeStyle][task 17] enable Ruff F811 rule in python/paddle/base #57398

merged 1 commit into from
Sep 16, 2023

Conversation

ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Sep 15, 2023 •
edited by SigureMo
Loading

PR types

Others

PR changes

Others

Description

fix Redefinition of unused
@gouzil

@paddle-bot
Copy link

paddle-bot bot commented Sep 15, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 15, 2023
@gouzil gouzil mentioned this pull request Sep 16, 2023
Closed
@gouzil
Copy link
Member

gouzil commented Sep 16, 2023

看样子好像是删了什么不该删的，需要修一下

@SigureMo
Copy link
Member

看样子好像是删了什么不该删的，需要修一下

这几个目测没什么问题，我先 rerun 下 coverage

SigureMo
SigureMo approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo changed the title [CodeStyle][task 17] enable Ruff F811 rule in python/paddle/base [CodeStyle][task 17] enable Ruff F811 rule in python/paddle/base Sep 16, 2023
@SigureMo SigureMo merged commit b0b71d2 into PaddlePaddle:develop Sep 16, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Sep 18, 2023
@ooooo-create ooooo-create deleted the ooooo/F811 branch September 23, 2023 05:27
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@ooooo-create
[CodeStyle][task 17] enable Ruff F811 rule in python/paddle/base (P…
948b484 
…addlePaddle#57398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees
No one assigned
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ooooo-create @gouzil @SigureMo @luotao1